Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary generated new lines in star.sql #651

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

courentin
Copy link
Contributor

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

Description & motivation

After the release of sqlfluff 1.3.0, we had some errors because the star macro was generating new lines before the macro. This PR fix it.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@courentin
Copy link
Contributor Author

Can someone have a look at this tiny PR please?

Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @courentin!

@joellabes joellabes merged commit acf4c81 into dbt-labs:main Sep 2, 2022
@courentin
Copy link
Contributor Author

Would it be possible to trigger a dbt-utils bug fix release so that I can upgrade sqlfluff? :)

@joellabes
Copy link
Contributor

Working on this as we speak! Looking to get a patch version and a first beta of 1.0.0 out in the next day or so. Sorry for the delay here 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants