Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated table argument from unpivot() #671

Merged

Conversation

miles170
Copy link
Contributor

@miles170 miles170 commented Sep 15, 2022

resolves #670

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Remove the obsolete table argument, which has been replaced by relation

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@miles170 miles170 force-pushed the remove-deprecated-table-argument branch from 702361b to bc27c59 Compare September 15, 2022 05:51
@miles170 miles170 force-pushed the remove-deprecated-table-argument branch from bc27c59 to 1057d0c Compare September 15, 2022 06:14
@joellabes
Copy link
Contributor

@miles170 That was quick! Will check this out in the morning, but looks great 🌟

@joellabes joellabes changed the base branch from main to utils-v1 September 19, 2022 03:12
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! Thanks @miles170

@joellabes joellabes merged commit 4a218df into dbt-labs:utils-v1 Sep 19, 2022
@miles170 miles170 deleted the remove-deprecated-table-argument branch September 19, 2022 03:15
@joellabes joellabes mentioned this pull request Sep 19, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated table argument from unpivot()
2 participants