Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo of not_null_proportion in README.md #853

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

PChambino
Copy link
Contributor

This is a:

  • documentation update

Description & motivation

I was looking if not_null_proportion supported grouping and noticed this inconsistency in the README which confused me about which was the correct spelling. It is a small change, but hopefully avoids confusion for people looking at it in the future.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PChambino !

@dbeatty10 dbeatty10 added this pull request to the merge queue Apr 18, 2024
Merged via the queue into dbt-labs:main with commit 72d087b Apr 18, 2024
1 check passed
@PChambino PChambino deleted the patch-1 branch June 5, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants