Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev-requirements for new pip syntax #870

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Update dev-requirements for new pip syntax #870

merged 1 commit into from
Mar 1, 2024

Conversation

gwenwindflower
Copy link
Contributor

Our CI is broken because pip syntax has changed for direct git references of packages

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

We want the package to work.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

dave-connors-3
dave-connors-3 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@dave-connors-3 dave-connors-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! 🦞

@gwenwindflower gwenwindflower added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 677ae1a Mar 1, 2024
6 checks passed
@gwenwindflower gwenwindflower deleted the fix/update-dev-requirements branch March 1, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-connors-3 dave-connors-3 dave-connors-3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwenwindflower @dave-connors-3