Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the correct language identifier in the code block of the document #876

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Set the correct language identifier in the code block of the document #876

merged 1 commit into from
Apr 10, 2024

Conversation

yamotech
Copy link
Contributor

resolves #

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

yamotech
yamotech commented Mar 14, 2024
View reviewed changes
CHANGELOG.md
@@ -181,14 +181,14 @@ The call signature of `deduplicate` has changed. The previous call signature is
- The `relation_alias` argument has been removed as the macro now supports `relation` as a string directly. If you were using `relation_alias` to point to a CTE previously then you can now pass the alias directly to `relation`.

Before:
```jinja
```sql
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were several places where I was not sure whether to use sql or jinja as the language identifier.
Which is better, sql or jinja?

For now, I'm trying to unify it to sql.

dbeatty10
dbeatty10 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Thank you for these updates @yamotech !

@dbeatty10 dbeatty10 added this pull request to the merge queue Apr 10, 2024
Merged via the queue into dbt-labs:main with commit 951d087 Apr 10, 2024
1 check passed
@yamotech yamotech deleted the set-the-correct-language-identifier-in-the-code-block-of-the-document branch April 11, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamotech @dbeatty10