Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirects for /guides/legacy/ #1643

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Add redirects for /guides/legacy/ #1643

merged 7 commits into from
Jul 19, 2022

Conversation

jtcohen6
Copy link
Collaborator

I don't understand redirects well enough to know why the changes to _redirects in #1420 aren't working quite right, but it's clear that these aren't being redirected right now:

We link to these in a variety of external places, so it would be best to get the redirects working again. This was a manual attempt based on searching / combing through the file.

@netlify
Copy link

netlify bot commented Jun 30, 2022

Deploy Preview for docs-getdbt-com canceled.

Name Link
🔨 Latest commit ed66004
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/62d6f3c74048ca000809a9b9

@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Jun 30, 2022
@jtcohen6
Copy link
Collaborator Author

@runleonarun Looks like there's a merge conflict between the redirects I'm proposing, and the one in the current branch:

<<<<<<< fix/guides-redirects
/docs/best-practices	/guides/legacy/best-practices	302
=======
/docs/best-practices	/guides/best-practices	302
>>>>>>> current

There's a lot of content in the "legacy" best practices page, which is previously where folks would land when they were linked to /docs/best-practices. Compared to which, the new "best practice guides" landing page has only the new guide to project structure. Would it be possible to add a link to the legacy best practices there, too? If so, then I'd feel more comfortable accepting the redirect currently in current.

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtcohen6 I think I resolved all the conflict and removed the duplicated redirects. Let's merge this and see how it goes!

@runleonarun runleonarun merged commit 498f01c into current Jul 19, 2022
@runleonarun runleonarun deleted the fix/guides-redirects branch July 19, 2022 18:28
runleonarun added a commit that referenced this pull request Jul 19, 2022
* Update gitignore.md

updated typo

* Update which-jinja-docs.md

* Update change-billing.md

removed image which was errroring out

* Update payment-accepted.md

updated formatting as it was formatted incorrectly in the live site

* Update managed-repo.md

updated spacing

* Update which-jinja-docs.md

updated broken links

* Update create-dependencies.md

updated broken link

* Update run-downtime.md

updated links

* Update example-projects.md

updated getting started guide link

* Update why-version-2.md

updated sidebar capitalization

* Update checking-logs.md

added capitalization

* Update failed-prod-run.md

added capitalization

* Update failed-tests.md

added capitalization

* Update run-downstream-of-seed.md

added capitalization

* Update run-one-model.md

added capitalization

* Update run-one-snapshot.md

added capitalization

* Update running-models-downstream-of-source.md

added capitalization

* Update snapshot-frequency.md

added capitalization

* Update leading-zeros-in-seed.md

added capitalization

* add content

* add content

* add content

* Update website/blog/2022-06-30-extract-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* add content

* add content

* Update dimensional-modeling.md

* Update website/docs/faqs/Git/managed-repo.md

committing Leona's suggestion

Co-authored-by: Leona B. Campbell <[email protected]>

* Update website/docs/faqs/Jinja/which-jinja-docs.md

committing Leona's suggestion

Co-authored-by: Leona B. Campbell <[email protected]>

* Update website/docs/faqs/Models/create-dependencies.md

committing Leona's suggestion

Co-authored-by: Leona B. Campbell <[email protected]>

* Update website/docs/faqs/Models/run-downtime.md

committing Leona's suggestion

Co-authored-by: Leona B. Campbell <[email protected]>

* Update website/docs/faqs/Project/example-projects.md

committing Leona's suggestion

Co-authored-by: Leona B. Campbell <[email protected]>

* Fix typo in dbt tests documentation page

* Update run-downtime.md

* Update slack.md

* Add content

* add content

* Update 2022-07-05-datediff-sql-love-letter.md

* add content

* small grammar fix

* changes to include expression metrics

* Fix all broken links in docs subfolder

* Fix blog post broken links

* fixes!

* Remove unused tag item from blog sidebar

* Update redirect

* Fix best practice link

* updating for link

* Update Oracle profile
- New python driver `python-oracledb` related changes which vastly simplifies dbt-oracle installation
- Wallet Configuration is explained in a better manner for 1-way TLS and m-TLS
- Content organization

* Update website/docs/docs/building-a-dbt-project/metrics.md

Co-authored-by: Jeremy Cohen <[email protected]>

* updating wording in metrics

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* reflecting changes in upgrade doc

* Add bold record to data change tables

* Update website/docs/terms/data-warehouse.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/docs/terms/data-warehouse.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/docs/terms/data-warehouse.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/docs/terms/data-warehouse.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-06-30-lower-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-06-30-lower-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-06-30-lower-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-06-30-lower-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-06-30-lower-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Add links

* Update website/blog/2022-06-30-lower-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update 2022-06-30-lower-sql-function.md

* Update website/blog/2022-06-30-extract-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* URL slug change

* Update website/blog/2022-06-30-coalesce-sql.md

Co-authored-by: Kira Furuichi <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kira Furuichi <[email protected]>

* Add links

* Apply suggestions from code review

Co-authored-by: Kira Furuichi <[email protected]>

* Add strikethrough

* small syntax fixes

* Fix hyperlink

* Update website/docs/terms/data-warehouse.md

Co-authored-by: Kira Furuichi <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kira Furuichi <[email protected]>

* updating docs

* fixing conflict

* Add updated redirects

* Fix jinja links

* Fix conflicts

* Update jinja reference redirect

* Add links

* Update website/blog/2022-06-30-extract-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-06-30-extract-sql-function.md

Co-authored-by: Kira Furuichi <[email protected]>

* Add truncate

* Update website/blog/2022-06-30-coalesce-sql.md

Co-authored-by: Kira Furuichi <[email protected]>

* Shorten reading list

* Update website/blog/2022-07-05-datediff-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-07-05-datediff-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-07-05-datediff-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-07-05-datediff-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-07-05-date-trunc-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-07-05-date-trunc-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-07-05-date-trunc-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Set featured to true

* Apply suggestions from code review

Co-authored-by: Kira Furuichi <[email protected]>

* https://github.com/dbt-labs/dbt-core/discussions/5468

* Up[date redirects

* Replace two more migration redirects

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture-metrics.md

Co-authored-by: Grace Goheen <[email protected]>

* remove images

* Update revenue-meme.png

* Update revenue-meme.png

* Update revenue-meme.png

* Update redirect

* Update website/blog/2022-07-12-change-data-capture-metrics.md

* Changes in response to review comments
- Changed the phrase one-way TLS to simply TLS
- Included link to official ADB documentation for wallet less TLS connection
- Changed service names to example service names
- Changed the ordering of connection methods. The ordering is TNS Alias, Connect String and Database hostname

* Update website/docs/guides/migration/versions/06-upgrading-to-v1.2.md

Co-authored-by: Jeremy Cohen <[email protected]>

* update for correctness and simplicities sake

* Update release date

* remove next.docs redirect

* remove extra properties

* Update redirects

* Add redirects back

* Update website/blog/2022-07-05-datediff-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Update 2022-07-05-datediff-sql-love-letter.md

* add git action to merge current branch into next

* Add wildcard for migration guides

* Add back specific redirects

* v1.2 docs omnibus (#1698)

* Add itertools module #1368

* Manifest v6 #1667

* Add set + zip #1635

* File selector method #1627

* Selector inheritance #1628

* Global config for target-path, log-path #1687

* Update website/docs/reference/dbt-jinja-functions/zip.md

Co-authored-by: Anders <[email protected]>

* Update website/docs/reference/dbt-jinja-functions/set.md

Co-authored-by: Anders <[email protected]>

* PR feedback

Co-authored-by: Anders <[email protected]>

* Update to `grants` documentation (#1707)

* Update docs on hooks re grants

* Update BQ language, link to docs

* Configuring grants, inheritance, reorg

* PR feedback

* Apply correct redirects for older versions

* Update snowflake-configs.md

In researching the use of time travel with dbt, I found the documentation to be mis-leading and thought I needed to change my dbt configuration. The comment that transient tables do not participate in time travel is not correct. Per Snowflake's documentation, Transient tables persist until they are dropped and the time travel default is 1 day and transient tables do not participate in fail safe.

* add content

* add links

* Add links

* Fix note

* Fix notes

* language tweaks

* Update website/blog/2022-07-13-star-sql-love-letter.md

Co-authored-by: Kira Furuichi <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kira Furuichi <[email protected]>

* Update website/blog/2022-07-12-change-data-capture.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture.md

Co-authored-by: Grace Goheen <[email protected]>

* Update website/blog/2022-07-12-change-data-capture.md

Co-authored-by: Grace Goheen <[email protected]>

* swap meme

* swap revenue for income

* Update website/docs/faqs/Accounts/change-billing.md

* Update website/docs/faqs/Accounts/change-billing.md

* Update git-revlist-error.md

* Update change-billing.md

* fix typo

`Coree` -> `Core`

* Update 06-upgrading-to-v1.2.md

* updates to SQL magic posts

minor updates to SQL magic posts

* stagger publish dates in past

- datediff + date_trunc must be after 7/13 (v1.2 updates)
- put all others in the past
- add a feature flag to one of them

* Remove out-of-date information from Azure AD docs (#1350)

Co-authored-by: Leona B. Campbell <[email protected]>

* Add redirects for /guides/legacy/ (#1643)

* Add redirects for guides

* Update _redirects

Co-authored-by: Leona B. Campbell <[email protected]>

Co-authored-by: mirnawong1 <[email protected]>
Co-authored-by: johnblust <[email protected]>
Co-authored-by: Kira Furuichi <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: 8vicat <[email protected]>
Co-authored-by: Callum McCann <[email protected]>
Co-authored-by: john-rock <[email protected]>
Co-authored-by: Anders <[email protected]>
Co-authored-by: Abhishek Singh <[email protected]>
Co-authored-by: Callum McCann <[email protected]>
Co-authored-by: Jeremy Cohen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Anders Swanson <[email protected]>
Co-authored-by: John Rock <[email protected]>
Co-authored-by: Jason Karlavige <[email protected]>
Co-authored-by: Beaulieuj <[email protected]>
Co-authored-by: Jason Ganz <[email protected]>
Co-authored-by: Jason Ganz <[email protected]>
Co-authored-by: Amy Chen <[email protected]>
Co-authored-by: Pat Kearns <[email protected]>
Co-authored-by: Brian Jan <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants