Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro Mini Style SSOP20 modification #16

Merged
merged 11 commits into from
Jul 19, 2020
Merged

Pro Mini Style SSOP20 modification #16

merged 11 commits into from
Jul 19, 2020

Conversation

LaZsolt
Copy link
Collaborator

@LaZsolt LaZsolt commented Feb 10, 2020

Hi David!

New Pro Mini style boards equipped with LGT8F238P only. So I changed boards.txt Pro Mini SSOP20 sections to LGT8F328P support. After this modification Arduino IDE can properly compile LGT8F328P specific register and port names. But it wasn't enough. In ...\cores\lgt8f\main.cpp RXD, TXD, SS pins are redirected when SSOP20 compiled. Now for SS default Arduino pin is 9. It is important in my IOT application which using ENC28J60 ethernet module.

Best regards: Zsolt

@LaZsolt
Copy link
Collaborator Author

LaZsolt commented Feb 10, 2020

and added some documents

@LaZsolt LaZsolt closed this Feb 10, 2020
@LaZsolt
Copy link
Collaborator Author

LaZsolt commented Feb 11, 2020

Hi David!

I'm new in Github, so it is my first pull request. Accidentally closed it yesterday...

My modification:

New Pro Mini style boards equipped with LGT8F238P only. So I changed boards.txt Pro Mini SSOP20 sections to LGT8F328P support.

menu_SSOP20

After this modification Arduino IDE can properly compile LGT8F328P specific register and port names. But it wasn't enough for me. In this repository the ...\cores\lgt8f\main.cpp redirecting RXD, TXD, SS pins when SSOP20 compiled. The default SS Arduino pin must be defined to 9.

It is important in my IOT application which using ENC28J60 ethernet module.

Best regards: Zsolt

@LaZsolt LaZsolt reopened this Feb 11, 2020
@dbuezas
Copy link
Owner

dbuezas commented Jul 19, 2020

Hey @LaZsolt!, did you work further on this or is it in a finished state?
I finally got the time to make a new release :)

@LaZsolt
Copy link
Collaborator Author

LaZsolt commented Jul 19, 2020

It is a finished state.

@dbuezas dbuezas merged commit fead0eb into dbuezas:master Jul 19, 2020
@dbuezas
Copy link
Owner

dbuezas commented Jul 21, 2020

As you noted, it's available in the new version. Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants