-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable recursive directory traversal in casc #21
Conversation
f036a88
to
911afd6
Compare
I'd prefer to sort the list of inserted/walked paths (not necessarily the list of argument paths) to get consistent behavior whatever the underlying files/filesystem/host. |
Updating the documentation and the casc's help with this new usage would be useful too. |
You mean sort the return from output of get_policy_files()? |
911afd6
to
442937f
Compare
I pushed an update, but the only issues I've addressed so far are rebasing on the latest merges and switching from println!() to eprintln!(). I'll look more closely at the rest next week. |
442937f
to
2e3daa1
Compare
2e3daa1
to
1d4e886
Compare
CI breakage is due to clap. It looks like they're making this breakage opt-in in an upcoming PR: clap-rs/clap#3830 |
This enables recursively discovering all policy files in the specified path(s), which is expected to be the most common use case. Additional ergonomics, like defaulting to CWD if no path is specified is future work.
1d4e886
to
88d01a4
Compare
It would be nice to add a test calling casc (with another PR). |
Yes, although I don't think that there's a clean way to do that in the current unit test framework, so we'd need to add some other test framework for it. That's fine, but it's more work, and lower priority than library testing IMO, so it may not be immediately forthcoming. |
This enables recursively discovering all policy files in the specified
path(s), which is expected to be the most common use case.
Additional ergonomics, like defaulting to CWD if no path is specified is
future work.