⚡️ zu: Switch from nom to winnow for signature parsing
#1090
+145
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
changed the title
nom to winnow for signature parsingnom to winnow for signature parsing
zeenix
force-pushed
the
port-to-winnow
branch
from
3b6c98e
to
0b50402
Compare
We already depend on it indirectly so it's not exactly a new dependency and it will help us optimize signature parsing and remove the `nom` dependency in a following commit.
This brings in 2 benefits: * The signature parsing code is now up to 30% faster. This directly translates to encoding/decoding speed of variants (used extensively in the D-Bus/gvariant world). This is the path that saw the least optimization in 5.0.0. * We'll now be able to remove `nom` and `minimal-lexical` deps (recently introduced in 5.0.0) in a following commit. Apparently `winnow` was already our indirect dependency so no new deps needed.
zeenix
force-pushed
the
port-to-winnow
branch
from
0b50402
to
df6b4e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in 2 benefits:
The signature parsing code is now up to 30% faster. This directly translates to encoding/decoding speed of variants (used extensively in the D-Bus/gvariant world). This is the path that saw the least optimization in 5.0.0.
Removal of
nomandminimal-lexicaldeps (recently introduced in 5.0.0). Apparentlywinnowwas already our indirect dependency so no new deps needed.