🚸 zv: Make signature parameter generic #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
force-pushed
the
zv-signature-generic
branch
3 times, most recently
from
a67a127
to
90989ff
Compare
This doesn't affect our users but gives us some features.
So that people can pass strings directly and let us worry about conversion to a `Signature` instance. This involves changing some public methods to return a Result but they are rarely used directly.
zeenix
force-pushed
the
zv-signature-generic
branch
from
90989ff
to
6511249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that people can pass strings directly and let us worry about conversion to a
Signatureinstance.This involves changing some public methods to return a Result but they are rarely used directly.