Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING: fix a few typos and a minor rewording #435

Merged
merged 2 commits into from
Aug 10, 2023
Merged

CONTRIBUTING: fix a few typos and a minor rewording #435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0451a13
✏️ CONTRIBUTING: fix a few typos
whot Aug 8, 2023
0323953
✏️ CONTRIBUTING: minor rewording for extra clarification
whot Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing to zbus

We welcomes contribution from everyone in the form of suggestions, bug reports, pull requests, and
We welcome contributions from everyone in the form of suggestions, bug reports, pull requests, and
feedback. This document gives some guidance if you are thinking of helping us.

Please reach out here in a Github issue, or in the
Expand All @@ -12,7 +12,7 @@ you contribute.
You can create issues [here](https://github.com/dbus2/zbus/issues/new). When
reporting a bug or asking for help, please include enough details so that the people helping you
can reproduce the behavior you are seeing. For some tips on how to approach this, read about how to
produce a [Minimal, Complete, and Verifiable example](https://stackoverflow.com/help/mcve).
produce a [Minimal, Complete, and Verifiable Example](https://stackoverflow.com/help/mcve).

When making a feature request, please make it clear what problem you intend to solve with the
feature, any ideas for how the crate in question could support solving that problem, any possible
Expand Down Expand Up @@ -43,11 +43,11 @@ Same rules apply here as for bug reports and feature requests. Plus:

### Legal Notice

When contributing to this project, you **implicitly** declare that you:
When contributing to this project, you **implicitly** declare that:

* have authored 100% of the content.
* have the necessary rights to the content.
* agree to providing the content under the [project's license](LICENSE).
* you have authored 100% of the content,
* you have the necessary rights to the content, and
* you agree to providing the content under the [project's license](LICENSE).
zeenix marked this conversation as resolved.
Show resolved Hide resolved

## Running the test suite

Expand All @@ -72,8 +72,8 @@ and clippy doesn't see anything wrong with the code:
cargo clippy -- -D warnings
```

Please not that there are times when clippy is wrong and you know what you are doing. In such cases,
it's acceptable to tell clippy to
Please note that there are times when clippy is wrong and you know what you are doing. In such
cases, it's acceptable to tell clippy to
[ignore the specific error or warning in the code](https://github.com/rust-lang/rust-clippy#allowingdenying-lints).

If you intend to contribute often or think that's very likely, we recommend you setup the following git
Expand Down
Loading