Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zb: Add missing nix feature #568

Merged
merged 1 commit into from
Feb 4, 2024
Merged

zb: Add missing nix feature #568

merged 1 commit into from
Feb 4, 2024

Conversation

bilelmoussaoui
Copy link
Contributor

The nix::unistd::Uid API requires the user feature, per https://docs.rs/nix/0.26.4/nix/unistd/struct.Uid.html

Somehow it worked out by luck as some other dependency was enabling that feature...

The nix::unistd::Uid API requires the user feature, per https://docs.rs/nix/0.26.4/nix/unistd/struct.Uid.html

Somehow it worked out by luck as some other dependency was enabling that feature...
@ogoffart
Copy link

ogoffart commented Feb 4, 2024

It worked before because the feature was was bought up by the xdg_home crate.
But the new release of the xdg_home create a few hours ago doesn't depend on the nix crate anymore and therefore broke the zbus crate.
And now zbus and therefore most crates that depends on it are no longer building

A new 3.x release of the zbus crate with this patch would solve the problem and would be much appreciated

@bilelmoussaoui
Copy link
Contributor Author

It worked before because the feature was was bought up by the xdg_home crate. But the new release of the xdg_home create a few hours ago doesn't depend on the nix crate anymore and therefore broke the zbus crate. And now zbus and therefore most crates that depends on it are no longer building

A new 3.x release of the zbus crate with this patch would solve the problem and would be much appreciated

I see, thanks for the investigation.

@zeenix
Copy link
Contributor

zeenix commented Feb 4, 2024

I'm so sorry. I didn't realise releasing a package that removes a dependency could break everything. 🤦‍♂️

I'll cherry-pick on 3.x branch soon and roll out a release.

@zeenix
Copy link
Contributor

zeenix commented Feb 4, 2024

I'll cherry-pick on 3.x branch soon and roll out a release.

oh this was for the 3.x branch. We don't need it on main (4) branch? 🤔

@bilelmoussaoui
Copy link
Contributor Author

I'll cherry-pick on 3.x branch soon and roll out a release.

oh this was for the 3.x branch. We don't need it on main (4) branch? 🤔

You already have it in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants