🚩 zb: Disable UDS support on Windows for tokio #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tokio currently [does not support Unix domain sockets on Windows][tuds], there is no reason to enable UDS support on Windows+tokio. This also fixes a build warning against rust nightly: ```rust error: field `0` is never read --> zbus\src\connection\builder.rs:45:16 | 45 | UnixStream(UnixStream), | ---------- ^^^^^^^^^^ | | | field in this variant | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 45 | UnixStream(()), | ~~ ``` [tuds]: tokio-rs/tokio#2201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tokio currently does not support Unix domain sockets on Windows, there is no reason to enable UDS support on Windows+tokio. This also fixes a build warning against rust nightly: