Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing logical border color properties #478

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

sherlockdoyle
Copy link
Contributor

Closes #474

@github-actions github-actions bot added the context-v2 Related to tailwind-merge v2 label Oct 2, 2024
Copy link

codspeed-hq bot commented Oct 3, 2024

CodSpeed Performance Report

Merging #478 will degrade performances by 64.52%

Comparing sherlockdoyle:main (b93b2d9) with main (63b477e)

Summary

❌ 4 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sherlockdoyle:main Change
collection with cache 20 ms 28.9 ms -30.84%
heavy 4.9 ms 8.6 ms -42.95%
init 4.8 ms 7.7 ms -38.18%
simple 4.7 ms 13.3 ms -64.52%

@dcastil dcastil added the bugfix label Oct 3, 2024
@dcastil
Copy link
Owner

dcastil commented Oct 3, 2024

Hey @sherlockdoyle! 👋

Thank you for submitting a PR with the fix, I appreciate that a lot! Looks like I overlooked the logical border color properties in #210.

By the way ignore the codspeed perf report (the results are quite imprecise) and the broken metrics report action. Have to fix that at some point.

Copy link
Owner

@dcastil dcastil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again!

@dcastil dcastil merged commit 9ec6338 into dcastil:main Oct 3, 2024
3 of 5 checks passed
@dcastil dcastil changed the title Adds support for logical border color properties Add missing logical border color properties Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

This was addressed in release v2.5.3.

@dcastil dcastil added bug Something isn't working and removed bugfix labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working context-v2 Related to tailwind-merge v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical border color properties does not work with generic border color
2 participants