Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit job to github actions and correct linter issues #44

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

pbadillatorrealba
Copy link
Member

@pbadillatorrealba pbadillatorrealba commented Dec 27, 2022

Changes:

  • Pre-commit is added to the github actions so that every time a pr or merge is made to master a QA check is performed. The previous replaces the flake8 check that was done in a github action, separating it into two independent jobs: pre-commit and pytest.
  • QA checks are now more comprehensive with pre-commit: errors with flake and styles with black and isort.
  • Many style and type changes are made to the code to to correct the problems shown by precommit.
  • In addition, a new linter was experimentally tested with more demanding rule sets than precommit: ruff. It was configured in pyproject.toml and the errors associated with the selected rules were corrected.

@pbadillatorrealba pbadillatorrealba changed the title Add precommit job to github actions and correct errors Add precommit job to github actions and correct linter issues Jan 2, 2023
@pbadillatorrealba pbadillatorrealba marked this pull request as ready for review January 16, 2023 00:58
@pbadillatorrealba pbadillatorrealba merged commit 96a4541 into master Jan 16, 2023
@pbadillatorrealba pbadillatorrealba deleted the feature/pre-commit branch January 16, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant