New: Typescript 4.7+ compatibility #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't wait for this PR to be merged! |
rcari
approved these changes
Oct 21, 2022
reyawn
approved these changes
Feb 13, 2023
|
Seems that this was removed as per 45f1f37 to fix issues with UMD, but the "fix" broke other things. |
|
Fixed in #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 4.7^ with mode resolution strategy set to nodenext, is confused about finding export = in d.ts file and complains about default import not being allowed (when imported as import Long from "long") as the heuristics used by typescript to guess seems to be inaccurate. Having export default would help fix this.