Change source of truth for types to umd/index.d.ts to resolve issue with typescript import in 5.x (Resolves #109) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue with typescript import in 5.x
SimplyLinn
changed the title
|
@dcodeIO hello! Could you review the PR? |
|
Have ya'll verified that the proposed change indeed works for both ESM and CJS/UMD? |
|
@dcodeIO we're trying to move a project from CJS to ESM, and it looks like if we swap the imports like in this PR, it works in both CJS and ESM. |
|
Would love to get this merged! 🙏 |
|
Also would love to get this merged. Requires we enable |
|
@dcodeIO Were you able to review this? We need this fix. I have tested it as well and it works fine. |
|
Any news ? |
tec27
added a commit
to ShieldBattery/ShieldBattery
that referenced
this pull request
Sep 17, 2024
… removed if dcodeIO/long.js#130 ever gets merged.
tec27
added a commit
to ShieldBattery/ShieldBattery
that referenced
this pull request
Oct 3, 2024
… removed if dcodeIO/long.js#130 ever gets merged.
jskrable
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR to resolve this issue (#124) ended up duplicating the types to the umd module.
Moving the source-of-truth to the
./umd/index.d.tsfile enables the./index.d.tsfile to import the class from the umd subdirectory with no issues. The other way around, however, seems to be the cause of the issues.My suggestion is to move the source of truth to the umd declaration file, and import it from the root index.d.ts, as to avoid duplicated code, while still keeping the types functional.
This would resolve #109