add SVR4 support #153
Open
add SVR4 support #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! Have you verified that this causes the subprocess functions to work on those platforms? We unfortunately don't currently have any CI that could automatically test that. 🙁 Also, how would you like to be credited in the AUTHORS file? |
|
@Low-power and I have tested it on Oracle Solaris and openindiana. And they works fine. But cygwin still need to test later. |
dcreager
approved these changes
May 31, 2019
Sounds good. If there are any cygwin failures we can address them then. |
|
I am going to support Cygwin in a separate pull-request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.