Implement new gometalinter capabilities and take care of warnings about them #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
In drud/build-tools#42 @tannerjfco improved our handling of gometalinter quite a lot, and we should use that.
How this PR Solves The Problem:
gofmt -s
which insists on some simplifications in addition to the normal gofmt behavior. These can of course be calmed with a simple comment.Key new issues:
Manual Testing Instructions:
You may want to look at the changes commit-by-commit so there's not just a whole pile of changes.
Automated Testing Overview:
Related Issue Link(s):
drud/build-tools#42 was the build-tools upgrade for gometalinter.
Release/Deployment notes: