Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using glue_data(.x) instead of glue(.envir) #1990

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

ddsjoberg
Copy link
Owner

What changes are proposed in this pull request?

  • Updated use of glue::glue(.envir) to glue::glue_data(.x) when the argument was not a proper environment.

If there is an GitHub issue associated with this pull request, please provide link.
closes #1989


Reviewer Checklist (if item does not apply, mark is as complete)

  • PR branch has pulled the most recent updates from main branch.
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • All GitHub Action workflows pass with a ✅

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg ddsjoberg changed the title Using glue_data(.x) instead of glue(.envir) Using glue_data(.x) instead of glue(.envir) Sep 19, 2024
@ddsjoberg ddsjoberg merged commit d9b1952 into main Sep 19, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the 1989-glue-revdep-updates branch September 19, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure with dev glue
1 participant