Update in tbl_ard_summary() to assign default summary types for non-standard ARDs
#2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melkiades
reviewed
Sep 26, 2024
Melkiades
reviewed
Sep 26, 2024
Comment on lines
316
to
321
| ard <- | ||
| structure(list(group1 = c("trt", "trt", "trt", "trt", "trt", | ||
| "trt"), group1_level = list("Drug A", "Drug A", "Drug B", "Drug B", | ||
| "Drug A", "Drug B"), variable = c("time", "time", "time", | ||
| "time", "age", "age"), variable_level = list(12, 24, 12, 24, | ||
| NULL, NULL), context = c("survival", "survival", "survival", |
There was a problem hiding this comment.
something is off with the styler here
There was a problem hiding this comment.
You don't like this style?? 😝😝😝
Melkiades
reviewed
Sep 26, 2024
Comment on lines
301
to
314
| # This ARD was created with this code: | ||
| # cards::bind_ard( | ||
| # survival::survfit(survival::Surv(ttdeath, death) ~ trt, trial) |> | ||
| # cardx::ard_survival_survfit(times = c(12, 24)) |> | ||
| # dplyr::filter(stat_name %in% c("estimate")) |> | ||
| # dplyr::mutate( | ||
| # fmt_fn = list("xx.x%"), | ||
| # group1_level = unlist(group1_level) |> as.character() |> as.list() | ||
| # ), | ||
| # cardx::ard_stats_t_test_onesample(trial, variables = age, by = trt) |> | ||
| # dplyr::filter(stat_name %in% c("estimate")) | ||
| # ) |> | ||
| # dplyr::select(-cards::all_missing_columns()) |> | ||
| # dput() |
There was a problem hiding this comment.
why not creating it? does it take a long time?
There was a problem hiding this comment.
OH boy, IDK what I was thinking! Updated to just build the ARDs. THANK YOU for questioning haha
Melkiades
approved these changes
Sep 26, 2024
Co-authored-by: Davide Garolini <[email protected]>
|
Thank you so much @Melkiades !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
tbl_ard_summary()to better handle non-standard ARDs (i.e. not our typical continuous or categorical summaries) by assigning them a default summary type. (in thetbl_ard_*()workflows, don't assign newgts_columnif it is already present #1991)The most common way to determine how a variable will be summarized (e.g. continuous or categorial) is with the context column. This works well for the standard univariate summaries, but when we incorporate non-standard ARDs, no default type was assigned.
If there is an GitHub issue associated with this pull request, please provide link.
closes #1999
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.mdwith the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")usethis::use_spell_check()again