Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tbl_ard_hierarchical() function. #2022

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Oct 3, 2024

I am wondering if this function is even needed. Functions like tbl_ard_summary() and tbl_ard_continuous() are general structures that can house many many types of tables, and re-used to help construct more complex tables.

These structures are so specific to these AE (and related) tables. Even when people are using an ARD framework, it seems it would be easier to to just build the table then grab the ARD from the table. 🤔🤔🤔


Reviewer Checklist (if item does not apply, mark is as complete)

  • PR branch has pulled the most recent updates from main branch.
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • All GitHub Action workflows pass with a ✅

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

Copy link
Collaborator

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Daniel! I know it's very basic right now but it does the job fine so I think it's good to go and we can come back and polish it up later - just a few minor suggestions from me.

R/tbl_ard_hierarchical.R Outdated Show resolved Hide resolved
R/tbl_ard_hierarchical.R Outdated Show resolved Hide resolved
@edelarua
Copy link
Collaborator

edelarua commented Oct 4, 2024

I am wondering if this function is even needed. Functions like tbl_ard_summary() and tbl_ard_continuous() are general structures that can house many many types of tables, and re-used to help construct more complex tables.

These structures are so specific to these AE (and related) tables. Even when people are using an ARD framework, it seems it would be easier to to just build the table then grab the ARD from the table. 🤔🤔🤔

That's true, I guess it just gives people more options since we don't really know how people will be using cards yet, or if there's a use case where it would be simpler to use the tbl_ard_*() function instead of directly calling the tbl_*() function.

Copy link
Collaborator

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel!!!

@ddsjoberg
Copy link
Owner Author

Thank you @edelarua !!

@ddsjoberg ddsjoberg merged commit f3b4ce4 into main Oct 4, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the tbl_ard_hierarchical branch October 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants