-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tbl_ard_hierarchical()
function.
#2022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Daniel! I know it's very basic right now but it does the job fine so I think it's good to go and we can come back and polish it up later - just a few minor suggestions from me.
That's true, I guess it just gives people more options since we don't really know how people will be using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel!!!
Thank you @edelarua !! |
I am wondering if this function is even needed. Functions like
tbl_ard_summary()
andtbl_ard_continuous()
are general structures that can house many many types of tables, and re-used to help construct more complex tables.These structures are so specific to these AE (and related) tables. Even when people are using an ARD framework, it seems it would be easier to to just build the table then grab the ARD from the table. 🤔🤔🤔
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# gtsummary (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again