Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate internal hierarchy processing from summary functions #2034

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

edelarua
Copy link
Collaborator

@edelarua edelarua commented Oct 7, 2024

What changes are proposed in this pull request?

  • Created separate internal processing function .add_gts_column_to_cards_hierarchical() from .add_gts_column_to_cards_summary() and removed hierarchical argument from internal function .add_table_styling_stats().

Closes #2033


Reviewer Checklist (if item does not apply, mark is as complete)

  • PR branch has pulled the most recent updates from main branch.
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • All GitHub Action workflows pass with a ✅

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

Copy link
Owner

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for making the separation!

@ddsjoberg ddsjoberg merged commit b183b75 into main Oct 9, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the 2033_sep_hierarchy_internals branch October 9, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate internal hierarchy processing from summary functions
2 participants