add support for not installed graphviz (dot)

[anb0s]

We are facing this problem with own distributions without installed graphviz, but delivered with eclipse e.g. in tools folder.

We do not want to add this to Windows system or user PATH as our Eclipse distibution contains all tools.

Would it be possible to configure the path to dot like it's possible in PlantUML plugin also for AsciiDoctor:

Thanks!

[anb0s]

May be the ASP can be adapted to accept environment variables in ASPServerAdapter.startServer() similar to launcher.setPathToJavaBinary(pathToJavaBinary), e.g.: launcher.setEnvironment(env) with Map<String, String> env; that can be configured by user in the preferences of AsciiDoctor editor in new text field or table with name and value.
GRAPHVIZ_DOT=tools/graphviz/bin/dot.exe

ASP would set this if configured:

Map<String, String> env = null;
...
ProcessBuilder pb = new ProcessBuilder(command);
if (env != null) {
  Map<String, String> pbEnv = pb.environment();
  pbEnv.putAll(env);
}

What do you think?

[de-jcup]

Sorry for the late response - I was very busy. Your suggestion should solve the problem.

[de-jcup]

Currently still busy because auf #333 and porting all my plugins... After this has been done I will concentrate on solving issues on asciidoctor editor ...

[de-jcup]

Hm... Asciidoctor intelliJ seems to do it this way:
https://github.com/asciidoctor/asciidoctor-intellij-plugin/blob/57ad18b78bf1d414f342e87eb706310a491b92fd/src/main/java/org/asciidoc/intellij/AsciiDoc.java#L1034-L1037

[de-jcup]

With https://github.com/de-jcup/asp/releases/tag/v1.3.0 ASP server can now be started with custom environment entries.

[de-jcup]

Either implementation has a configuration page for custom environment entries (in this case ASP and CLI variant must both provide all user entries) - or a dedicated GraphViz preference entry will be set (also in this case ASP and CLI variant are necessary).

[anb0s]

Hm... Asciidoctor intelliJ seems to do it this way:
https://github.com/asciidoctor/asciidoctor-intellij-plugin/blob/57ad18b78bf1d414f342e87eb706310a491b92fd/src/main/java/org/asciidoc/intellij/AsciiDoc.java#L1034-L1037

The solution with Env varibale is also valid and is used in eclox plugin and other doxygen / graphviz / dot related tools.

Here the customized location without system Env-entry is usefull for multiple Eclipse distributions with all the tools "embedded"...

[anb0s]

Either implementation has a configuration page for custom environment entries (in this case ASP and CLI variant must both provide all user entries) - or a dedicated GraphViz preference entry will be set (also in this case ASP and CLI variant are necessary).

Can we set this manually in a preference file form workspace?

[de-jcup]

I created #369 to provide custom environment entries for ASP and also for installed asciidoctor.
Will be contained inside Version 2.5.0 (upcoming release on eclipse marketplace in the next weeks).

Here the screen shot from the feature:

[de-jcup]

Hmm... after some tests before releasing, there are some odd situations:

• changing an environment to different value results in 2 or 3 running ASP server instances!
  Looks like a bug which must be fixed before releasing
• when I set GRAPHVIZ_DOT it is inside the JVM process of ASP server, okay, but when using something like `/notexisting/dot" and set it as this environment value, system installed dot will still be used?!?!
• maybe it becomes necessary to install newest graphviz from source (https://gitlab.com/graphviz/graphviz)

[de-jcup]

Seems to be necessary to treat the GRAPHVIZ_DOT variable special in ASP. So must wait for de-jcup/asp#44

[zieglerz]

Hi :)
We used to setup path to graphviz this way (tools folder inside Eclipse home). But in current version (v3.1.1) this is not working.

Any ideas, how to solve this?

Thank you in advance :)

We are facing this problem with own distributions without installed graphviz, but delivered with eclipse e.g. in tools folder.

We do not want to add this to Windows system or user PATH as our Eclipse distibution contains all tools.

Would it be possible to configure the path to dot like it's possible in PlantUML plugin also for AsciiDoctor:

Thanks!