Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide possibility to customize environment entries in asciidoctor process #369

Closed
de-jcup opened this issue Sep 7, 2021 · 1 comment
Closed

Provide possibility to customize environment entries in asciidoctor process #369

de-jcup opened this issue Sep 7, 2021 · 1 comment
Assignees
@de-jcup
Labels
enhancement New feature or request
Milestone
2.5.0

Comments

@de-jcup
Copy link
Owner

de-jcup commented Sep 7, 2021

In #322 there was a need to setup the GRAPHVIZ_DOT environment variable in ASP launches.

Instead of providing a specialized preference value for only this custom env entry, inside this issue we will

  • provide a dedicated preference page for custom environment entries
  • there will be a "enabled" checkbox as well, so we can globally disable all entries without removing tem
  • the custom environment entries will be used for ASP and also when using installed asciidoctor version
@de-jcup de-jcup self-assigned this Sep 7, 2021
@de-jcup de-jcup added the enhancement New feature or request label Sep 7, 2021
@de-jcup de-jcup added this to the 2.5.0 milestone Sep 7, 2021
@de-jcup de-jcup closed this as completed in 5dbf3ea Sep 7, 2021
@de-jcup de-jcup mentioned this issue Sep 7, 2021
Closed
de-jcup added a commit that referenced this issue Sep 7, 2021
@de-jcup
Fixed typo in preference title #369
d604afd
@de-jcup
Copy link
Owner Author

de-jcup commented Sep 7, 2021

With last commit we have now a dedicated preference page and can set custom environment entries:
image

vogella pushed a commit to vogellacompany/eclipse-asciidoctor-editor that referenced this issue Sep 17, 2021
@de-jcup @vogella
Fixed typo in preference title de-jcup#369
3534f34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@de-jcup