Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken gradle build #376

Closed
de-jcup opened this issue Oct 29, 2021 · 3 comments · Fixed by #377
Closed

Fix broken gradle build #376

de-jcup opened this issue Oct 29, 2021 · 3 comments · Fixed by #377
Assignees
Milestone

Comments

@de-jcup
Copy link
Owner

de-jcup commented Oct 29, 2021

Situation

Currently the gradle build fails because of dependency problems. seems to be related to bintray sundown.

Wanted

With de-jcup/asp#39 the ASP dependencies shall be accessible

As long as #371 is not full and 100% working the gradle dependencies should be maintained as well - so this issue.

Solution

  • drop jcenter repository setting
  • fix gradle dependencies so build works again
@de-jcup de-jcup added this to the 2.5.0 milestone Oct 29, 2021
@de-jcup de-jcup self-assigned this Oct 29, 2021
@de-jcup de-jcup changed the title Update gradle dependencies of ASP to maven central Fix broken gradle build Oct 29, 2021
@de-jcup
Copy link
Owner Author

de-jcup commented Oct 29, 2021

There are multiple problems appearing in current gradle build I will add comments here to document

From failing build https://github.com/de-jcup/eclipse-asciidoctor-editor/runs/4044342433

10 actionable tasks: 10 executed
* What went wrong:
Could not resolve all files for configuration ':asciidoctor-editor-gradle-dep:plugin_editor'.
> Could not find de.jcup.asp:asp-server-asciidoctorj-launcher:1.3.0.
  Searched in the following locations:
    - file:/home/runner/.m2/repository/de/jcup/asp/asp-server-asciidoctorj-launcher/1.3.0/asp-server-asciidoctorj-launcher-1.3.0.pom
    - file:/home/runner/.m2/repository/de/jcup/asp/asp-server-asciidoctorj-launcher/1.3.0/asp-server-asciidoctorj-launcher-1.3.0-dist.jar
    - https://repo.maven.apache.org/maven2/de/jcup/asp/asp-server-asciidoctorj-launcher/1.3.0/asp-server-asciidoctorj-launcher-1.3.0.pom
    - https://repo.maven.apache.org/maven2/de/jcup/asp/asp-server-asciidoctorj-launcher/1.3.0/asp-server-asciidoctorj-launcher-1.3.0-dist.jar
    - https://jcenter.bintray.com/de/jcup/asp/asp-server-asciidoctorj-launcher/1.3.0/asp-server-asciidoctorj-launcher-1.3.0.pom
    - https://jcenter.bintray.com/de/jcup/asp/asp-server-asciidoctorj-launcher/1.3.0/asp-server-asciidoctorj-launcher-1.3.0-dist.jar
  Required by:
      project :asciidoctor-editor-gradle-dep

But... https://mvnrepository.com/artifact/de.jcup.asp/asp-server-asciidoctorj-launcher/1.3.1 is available

Update: Yes.... 1.3.1 but not 1.3.0... just an update inside the dependencies necessary and it shall work.

@de-jcup
Copy link
Owner Author

de-jcup commented Oct 29, 2021

At my local maschine, a

./gradlew build 

on branch master fails with:

* What went wrong:
Could not resolve all files for configuration ':asciidoctor-converter-plugin:compile'.> Could not find nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:1.1.
  Searched in the following locations:    - file:/home/albert/.m2/repository/nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.1/markdown_to_asciidoc-1.1.pom
    - file:/home/albert/.m2/repository/nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.1/markdown_to_asciidoc-1.1.jar
    - https://repo.maven.apache.org/maven2/nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.1/markdown_to_asciidoc-1.1.pom
    - https://repo.maven.apache.org/maven2/nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.1/markdown_to_asciidoc-1.1.jar
  Required by:
      project :asciidoctor-converter-plugin

But... https://mvnrepository.com/artifact/nl.jworks.markdown_to_asciidoc/markdown_to_asciidoc/1.1 is available.

@de-jcup
Copy link
Owner Author

de-jcup commented Oct 29, 2021

https://mvnrepository.com/artifact/nl.jworks.markdown_to_asciidoc/markdown_to_asciidoc/1.1

gives following hint:

Note: this artifact is located at Spring Plugins repository (https://repo.spring.io/plugins-release/)

After setting this as an addition maven repository (https://repo.spring.io/plugins-release)
I got

Execution failed for task ':asciidoctor-converter-plugin:installLibraries'.
> Could not resolve all files for configuration ':asciidoctor-converter-plugin:compile'.
   > Could not resolve nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:1.1.
     Required by:
         project :asciidoctor-converter-plugin
      > Could not resolve nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:1.1.
         > Could not get resource 'https://repo.spring.io/plugins-release/nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.1/markdown_to_asciidoc-1.1.pom'.
            > Could not GET 'https://repo.spring.io/plugins-release/nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.1/markdown_to_asciidoc-1.1.pom'. Received status code 401 from server: Unauthorized

So there is a need to authenticate ?!?!

After some research I found
markdown-asciidoc/markdown-to-asciidoc#26 - there is an entry about a workaround using https://mvnrepository.com/artifact/ca.szc.thirdparty.nl.jworks.markdown_to_asciidoc/markdown_to_asciidoc (which is working) but unfortunately only version 1.0 is available

Update: At the mentioned issue it became clear that the new releases are available at jitpack .

de-jcup added a commit that referenced this issue Oct 29, 2021
- dropped jcenter dependency because no longer available
- added jitpack dependency as mentioned at github
  (see mentioned link in commit)
-
de-jcup added a commit that referenced this issue Oct 29, 2021
- renamed `AsiidoctorConfigFileSupport` to
`AcsiidoctorConfigFileSupport`
de-jcup added a commit that referenced this issue Oct 29, 2021
- the former asp version 1.3.0 is not available on
  maven central, but 1.3.1 so changed this inside
  build file
@de-jcup de-jcup linked a pull request Oct 29, 2021 that will close this issue
@de-jcup de-jcup closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant