Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test activator is used by wrapped Tycho OSGI parts #47

Closed
de-jcup opened this issue Dec 4, 2022 · 0 comments
Closed

Test activator is used by wrapped Tycho OSGI parts #47

de-jcup opened this issue Dec 4, 2022 · 0 comments
Assignees
@de-jcup
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@de-jcup
Copy link
Owner

de-jcup commented Dec 4, 2022

Situation

While implementing de-jcup/eclipse-asciidoctor-editor#371, the reference to eclipse-commons 1.1.1 did end up with a failing Asciidoctor Editor plugin on startup, because the activator from the testcase was not found...

The plugin.xml was inside the deployed version of eclipse-commons on maven central!

Wanted

Other plugins using eclipse-commons from maven central shall work

Solution

Drop plugin.xml before publishing to maven central - tested locally and this solves the problem.
@de-jcup de-jcup added this to the 1.2.0 milestone Dec 4, 2022
@de-jcup de-jcup self-assigned this Dec 4, 2022
@de-jcup de-jcup added the bug Something isn't working label Dec 4, 2022
@de-jcup de-jcup closed this as completed in 0db1891 Dec 4, 2022
de-jcup added a commit that referenced this issue Dec 4, 2022
@de-jcup
Changed maven and release build, closes #47
bf56601 
- plugin.xml is now replaced on build with a replacement_plugin.xml
  (which is empty)
- maven github workflow does not also archives artifacts of
  target-jar, so libs can be inspected before final release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@de-jcup