hyperscript: handles shared empty attrs, fixes MithrilJS#2821

dead-claudia · Sep 23, 2024 · 6c1c5cf · 6c1c5cf
1 parent 274cb2f
commit 6c1c5cf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/render/hyperscript.js b/render/hyperscript.js
@@ -38,7 +38,7 @@ function execSelector(state, vnode) {
 	vnode.tag = state.tag
 	vnode.attrs = {}
 
-	if (!isEmpty(state.attrs) && !isEmpty(attrs)) {
+	if (!isEmpty(state.attrs)) {
 		var newAttrs = {}
 
 		for (var key in attrs) {

diff --git a/render/tests/test-hyperscript.js b/render/tests/test-hyperscript.js
@@ -580,6 +580,15 @@ o.spec("hyperscript", function() {
 			o(nodeB.attrs.className).equals("b")
 			o(nodeB.attrs.a).equals("b")
 		})
+		o("handles shared empty attrs (#2821)", function() {
+			var attrs = {}
+
+			var nodeA = m(".a", attrs)
+			var nodeB = m(".b", attrs)
+
+			o(nodeA.attrs.className).equals("a")
+			o(nodeB.attrs.className).equals("b")
+		})
 		o("doesnt modify passed attributes object", function() {
 			var attrs = {a: "b"}
 			m(".a", attrs)