Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

更新文档中 targetAccountmethodAccount 的增减账户关系映射表 #109

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

ramsayleung
Copy link
Contributor

Description

更新文档中 targetAccountmethodAccount 的增减账户关系映射表,

从逻辑上讲, defaultCashAccounttargetAccount 是由用户配置的值,是属于变量; 而 plusAccountminusAccount 属于每笔交易的固有属性, 因此将固有属性 plusAccountminusAccount 作为表头, 变量作为随「收/支」而变化的值会让逻辑更清晰

Motivation and Context

#103

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  1. All CI task passed
  2. 账户的对应关系逻辑上保持一致

Is this change properly documented?

YES

Don't forget to add an entry to the CHANGELOG/README if necessary (new features, breaking changes, relevant internal improvements).

@ramsayleung ramsayleung requested a review from a team as a code owner June 11, 2023 21:14
@gaocegege gaocegege requested a review from Triple-Z June 12, 2023 03:57
@gaocegege
Copy link
Member

LGTM

Thanks for your contribution! 🎉 👍

Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Triple-Z Triple-Z merged commit 7cada01 into master Jun 12, 2023
@gaocegege gaocegege deleted the ramsay/update_readme_about_minus/plus_account branch November 13, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants