refact: clarify the type and txType in whole codebase
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend releasing the 2.x version for the breaking changes. /cc @gaocegege |
- `Type` stands for `Buy/Sell` or `In/Out`. - `TxType` is specific paying definition which can be various in every provider. Signed-off-by: Triple-Z <[email protected]>
Triple-Z
force-pushed
the
refact-type-txType-gh-60
branch
from
23e3bee
to
7b5a226
Compare
gaocegege
approved these changes
Nov 2, 2022
|
@gaocegege We can reply on CI though 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typestands forBuy/SellorIn/Out.TxTypeis the specific paying definition which can be various for every provider.BREAKING CHANGE: the config fields(
typeandtxType) forhuobiandhtsecproviders are redefined in this PR, so the user who used this tool before with those providers MUST modify the config forhuobiorhtsecprovider after upgrading the tool.resolves #60
Signed-off-by: Triple-Z [email protected]