tests: Fix crash in XWindowsKeyStateTests

debauchee · May 30, 2020 · 13a0359 · 13a0359
1 parent f23e8a6
commit 13a0359
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/lib/platform/XWindowsKeyState.h b/src/lib/platform/XWindowsKeyState.h
@@ -173,6 +173,6 @@ class XWindowsKeyState : public KeyState {
 public:
     SInt32                  group() const { return m_group; }
     void                    group(const SInt32& group) { m_group = group; }
-    KeyModifierMaskList    modifierFromX() const { return m_modifierFromX; }
+    KeyModifierMaskList& modifierFromX() { return m_modifierFromX; }
 #endif
 };
diff --git a/src/test/integtests/platform/XWindowsKeyStateTests.cpp b/src/test/integtests/platform/XWindowsKeyStateTests.cpp
@@ -150,7 +150,6 @@ TEST_F(XWindowsKeyStateTests, pollActiveModifiers_defaultState_returnsZero)
     ASSERT_EQ(0, actual);
 }
 
-#if 0 // TODO: fix, causes sigsegv
 TEST_F(XWindowsKeyStateTests, pollActiveModifiers_shiftKeyDownThenUp_masksAreCorrect)
 {
     MockKeyMap keyMap;
@@ -181,7 +180,6 @@ TEST_F(XWindowsKeyStateTests, pollActiveModifiers_shiftKeyDownThenUp_masksAreCor
     EXPECT_TRUE((modUp & KeyModifierShift) == 0)
         << "shift key still in mask - make sure no keys are being held down";
 }
-#endif
 
 TEST_F(XWindowsKeyStateTests, pollActiveGroup_defaultState_returnsZero)
 {