-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation on M1 macOS #1162
Conversation
export CMAKE_PREFIX_PATH="/opt/procursus:$QT_PATH:$CMAKE_PREFIX_PATH" | ||
export LD_LIBRARY_PATH="/opt/procursus/lib:$LD_LIBRARY_PATH" | ||
export CPATH="/opt/procursus/include:$CPATH" | ||
export PKG_CONFIG_PATH="/opt/procursus/lib/pkgconfig:$PKG_CONFIG_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know little about Procursus, but it seems strange to include Pocursus paths when Homebrew is detected.
Running file on all 3 executables shows they are not yet universal
Keep up the great effort |
Looks like this PR only attempts to fix building but not to create universal binaries. Also, Homebrew does not seems to support universal binaries, either. Homebrew/brew#10307 |
There are now conflicting files as part of this PR is covered by #1207 |
I get |
For anyone facing this, use this comment command. Also, I think this PR should be merged, Barrier running native Apple Arch in M1 MBA here! |
I've updated CI to build on Big Sur, but I want to make this PR use a conditional for compiling on M1. I still want older macOS releases to be supported by Barrier... |
@shymega universal binaries work on pretty much all versions of macOS, they've been a thing since the powerpc days |
@Absolucy OK. As long as Mojave, Catalina, and Big Sur are supported, I'm happy to merge. |
Could you share a zip of the app please? I haven't got it to work. Thanks. |
Of course! Here is my build. |
Thank you SO much🙏🏾 I had to run CHMOD-X on the each of the three executables in the MacOS folder in the app package but now it's working perfectly. |
i don't even know how this PR is open anymore considering that my fork is deleted |
Nor do I - do you still want it merged? I can checkout the PR and merge it myself if you want? |
Yeah, feel free. |
Right, OK, that's been merged. Thanks for the PR, its a welcome addition to our macOS support, both local builds and CI! |
Thanks, @Absolucy! |
Homebrew on M1 uses
/opt/homebrew
instead of/usr/local
In addition, I added support for Procursus, which uses apt and installs in
/opt/procursus
on both x86_64 and M1.