Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] properly declare FPIC #417

Merged
merged 1 commit into from
Aug 23, 2019
Merged

[CMake] properly declare FPIC #417

merged 1 commit into from
Aug 23, 2019

Conversation

AdrianKoshka
Copy link

use CMAKE_POSITION_INDEPENDENT_CODE instead of manually adding -fPIC to CXX args.

@AdrianKoshka
[CMake] properly declare FPIC
1bdc95a 
use CMAKE_POSITION_INDEPENDENT_CODE instead of manually addinf -fPIC to CXX args.

	modified:   CMakeLists.txt
@AdrianKoshka AdrianKoshka added enhancement New feature or request build-infra Build infrastructure bugs/PRs labels Aug 23, 2019
@AdrianKoshka AdrianKoshka merged commit 28466ee into master Aug 23, 2019
@AdrianKoshka AdrianKoshka deleted the pic-pie-cmake-fix branch August 23, 2019 19:48
@AdrianKoshka AdrianKoshka mentioned this pull request Aug 23, 2019
Closed
@ghost ghost mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build-infra Build infrastructure bugs/PRs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AdrianKoshka