Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let tray image blend into macOS menu bar #504

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

tiwoc
Copy link

@tiwoc tiwoc commented Nov 21, 2019

The expected style for macOS menu bar images is a template image than can adapt to the user's appearance settings. Also, high-res screens ("Retina" in Apple speak) need higher resolution images.

Without this PR (Light Mode):
before-light
Without this PR (Dark Mode):
before-dark


With this PR (Light Mode):
after-light
With this PR (Dark Mode):
after-dark

Based on /res/barrier.svg, I created black and transparent SVGs for the three icon states. I had to remove some details to make the image scale down to icon size without becoming too crowded, and I drew a new checkmark and the transfer arrow.

The expected style for macOS menu bar images is a template image than
can adapt to the user's appearance settings. Also, high-res screens
("Retina" in Apple speak) need higher resolution images.

Based on /res/barrier.svg, I created black and transparent SVGs for the
three icon states. I had to remove some details to make the image scale
down to icon size without becoming too crowded, and I drew a new
checkmark and the transfer arrow.
@AdrianKoshka AdrianKoshka merged commit d8e0394 into debauchee:master Nov 21, 2019
@shymega shymega added the macOS Related to macOS label Nov 29, 2019
@simons-public
Copy link

@tiwoc Thanks, this makes the menu bar icon so much better

@cschep
Copy link

cschep commented May 19, 2020

This looks awesome, is this part of any releases or do I need to run master to pick up this change?

Really nice, thanks @tiwoc !

@simons-public
Copy link

@cschep It's not in any of the releases, but you can get it in a compiled release of master from the published artifacts on Azure.

@galkinvv galkinvv mentioned this pull request Sep 30, 2020
@AllesMeins
Copy link

Is this only for the mac-version or is it the new standard for all versions? I'm running barrier on Linux (KDE) and I've been looking for a way to get a monochrome icon for quite some time...

@tiwoc
Copy link
Author

tiwoc commented Apr 11, 2021

This PR did only affect the Mac icon, that's right. It should be pretty easy to apply a similar change for Linux if a black and white icon fits the predominant style across the common desktop environments. I unfortunately don't have the time to do (and test) that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Related to macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants