-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Replace bundled gtest directory with Git submodule #721
Conversation
Oh, I can see CI is failing. Probably because the CI scripts don't initialise and pull Git submodules. Will look into it. |
Just removed the |
Oh, wait, that's a mistake.. v1.6.0 hasn't made that change yet. I messed up there. OK, will revert that last commit, and add gmock again. Sorry! |
OK, made some more mistakes, but should be fixed now. I've locked Google Mocking at v1.6.0. To give some clarification, Google Testing now has mocking in the same project, and the Google Mock repo is now archived, but the v1.6.0 tag still exists. I've created another Git submodule for gmock. My previous commits were mistaken, and I had messed it up a bit. Its late at night for me, and I think my code quality is suffering! |
Possibly should squash those last few commits into one.. |
Yeah, I really need |
I was just gonna squash and merge with the GitHub UI tbh. |
Merging in a sec. Is that alright, @p12tic - we good to go? |
Rebased on latest master. Looking into commits again, not all commits need squashing, as that would remove information. |
This PR replaces the bundled
/ext/gtest
directory with a Git submodule locked at the same release as before - 1.6.0 - but it should be considered to bump the release in the near future when and if possible.Thoughts?