This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Styling fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| </div> | ||
| {{/if}} {{/each}} | ||
| </div> <!-- again with the hacks ... hopefully this will fix the styling. The component is wrapped automatically in a div element, but that breaks the vanilla discourse styling. One can customize the component to be wrapped in another kind of html element, but as far as I can tell you can't just tell it not to wrap it at all --> |
There was a problem hiding this comment.
😂 I've seen/done this before in other templating languages like Handlebars to wrap frustrating stuff in something reasonably selectable with CSS. No shame if it's what it takes.
There was a problem hiding this comment.
Is it being wrapped in the div just applying some weird spacing or something? Haven't actually looked to see what this looks like yet.
There was a problem hiding this comment.
I found an officialish solution: emberjs/ember.js#4790
berleant
force-pushed
the
sb/134
branch
2 times, most recently
from
09455b9
to
e55d1c8
Compare
…ay something if there are no collectives
2 tasks
sarayourfriend
approved these changes
Jun 11, 2018
sarayourfriend
approved these changes
Jun 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these changes depend on a pull request I sent to discourse (see linked issue)