Allow line numbers to match debug() call in browser consoles #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible starting point to fixing file and line number mapping in the browser, #198 as well as for sourcemaps with browserify and webpack, #223
I'm not sure what of the full formatting scope that is done in enabled() or if it can be integrated into this approach for matching line numbers. This approach has the limitation that it needs to do formatting up front when debug() is called. This is because debug() has to return console.log() directly. i.e:
return console.log.bind(console, '%c%s +%sms', 'color: ' + self.color, namespace, interval)
to preserve line numbers.This limits to using bind() to add formatting to console.log().
Currently it supports the color formatting of namespace and ms interval. The ms interval is now directly after the namespace due to limitation that we can only prepend arguments to Function.prototype.bind().