Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smart werable pack and fix preview of SW on sdk7 #682

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

gonpombo8
Copy link
Contributor

No description provided.

@gonpombo8 gonpombo8 changed the title add smart werable pack and fix preview of SW on sdk7 [do not merge] add smart werable pack and fix preview of SW on sdk7 Jul 13, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2e1656e
Status: ✅  Deploy successful!
Preview URL: https://cfbfbc6e.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-smart-wearable-sdk7.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/smart-wearable-sdk7/dcl-sdk-7.3.2-5645907042.commit-fca5dcf.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/smart-wearable-sdk7/dcl-sdk-commands-7.3.2-5645907042.commit-fca5dcf.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/smart-wearable-sdk7/@dcl/inspector/dcl-inspector-7.3.2-5645907042.commit-fca5dcf.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/smart-wearable-sdk7-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/smart-wearable-sdk7

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.41 ⚠️

Comparison is base (7cd3d38) 73.77% compared to head (2e1656e) 73.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   73.77%   73.37%   -0.41%     
==========================================
  Files         312      314       +2     
  Lines       10470    10560      +90     
  Branches     1361     1375      +14     
==========================================
+ Hits         7724     7748      +24     
- Misses       2612     2670      +58     
- Partials      134      142       +8     
Impacted Files Coverage Δ
...kages/@dcl/sdk-commands/src/commands/init/index.ts 93.02% <ø> (ø)
...ages/@dcl/sdk-commands/src/commands/start/index.ts 27.72% <0.00%> (-0.28%) ⬇️
...ages/@dcl/sdk-commands/src/components/analytics.ts 100.00% <ø> (ø)
...commands/src/commands/pack-smart-wearable/index.ts 21.66% <21.66%> (ø)
...@dcl/sdk-commands/src/logic/project-validations.ts 82.92% <25.00%> (-6.27%) ⬇️
...ds/src/logic/portable-experience-sw-validations.ts 38.09% <38.09%> (ø)
...dk-commands/src/commands/start/server/endpoints.ts 5.26% <40.00%> (+0.96%) ⬆️
...ages/@dcl/sdk-commands/src/commands/build/index.ts 100.00% <100.00%> (ø)
...kages/@dcl/sdk-commands/src/commands/init/repos.ts 85.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonpombo8 gonpombo8 force-pushed the feat/smart-wearable-sdk7 branch 2 times, most recently from 52a6d85 to f808bbe Compare July 14, 2023 13:38
@gonpombo8 gonpombo8 changed the title [do not merge] add smart werable pack and fix preview of SW on sdk7 add smart werable pack and fix preview of SW on sdk7 Jul 19, 2023

export function help(options: Options) {
options.components.logger.log(`
Usage: 'sdk-commands build [options]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk-commands pack-smart-wearable

Usage: 'sdk-commands build [options]'
Options:'
-h, --help Displays complete help
--skip-build Skip build and use the file defined in scene.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add description for --skip-install

@gonpombo8 gonpombo8 merged commit 4abe944 into main Jul 24, 2023
@gonpombo8 gonpombo8 deleted the feat/smart-wearable-sdk7 branch July 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants