Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context menu hide on mousedown #687

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: context menu hide on mousedown #687

merged 1 commit into from
Jul 18, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Jul 17, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8ad33aa
Status:🚫  Build failed.

View logs

@nicoecheza nicoecheza marked this pull request as ready for review July 17, 2023 20:37
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/context-menu/dcl-sdk-7.3.2-5580381089.commit-9a81b38.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/context-menu/dcl-sdk-commands-7.3.2-5580381089.commit-9a81b38.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/context-menu/@dcl/inspector/dcl-inspector-7.3.2-5580381089.commit-9a81b38.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/context-menu-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/context-menu

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (14b71af) 74.51% compared to head (8ad33aa) 74.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
- Coverage   74.51%   74.49%   -0.03%     
==========================================
  Files         311      312       +1     
  Lines       10439    10442       +3     
  Branches     1353     1354       +1     
==========================================
  Hits         7779     7779              
- Misses       2535     2537       +2     
- Partials      125      126       +1     
Impacted Files Coverage Δ
.../@dcl/inspector/src/components/ContexMenu/index.ts 0.00% <0.00%> (ø)
...ges/@dcl/inspector/src/hooks/sdk/useContextMenu.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicoecheza nicoecheza merged commit 507247c into main Jul 18, 2023
@nicoecheza nicoecheza deleted the fix/context-menu branch July 18, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants