Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove postinstall #725

Merged
merged 1 commit into from
Sep 7, 2023
Merged

chore: remove postinstall #725

merged 1 commit into from
Sep 7, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 7, 2023

Remove postinstall, it was breaking the CLI E2E tests

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 69fb483
Status: ✅  Deploy successful!
Preview URL: https://eb280289.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-e2e-cli-test.js-sdk-toolchain.pages.dev

View logs

@cazala cazala marked this pull request as ready for review September 7, 2023 20:29
@cazala cazala enabled auto-merge (squash) September 7, 2023 20:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/e2e-cli-test/dcl-sdk-7.3.13-6114420084.commit-c4bd063.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/e2e-cli-test/dcl-sdk-commands-7.3.13-6114420084.commit-c4bd063.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/e2e-cli-test/@dcl/inspector/dcl-inspector-7.3.13-6114420084.commit-c4bd063.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/e2e-cli-test-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/e2e-cli-test

@cazala cazala merged commit 51030fe into main Sep 7, 2023
8 checks passed
@cazala cazala deleted the fix/e2e-cli-test branch September 7, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants