Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: location not defined #728

Merged
merged 1 commit into from
Sep 9, 2023
Merged

fix: location not defined #728

merged 1 commit into from
Sep 9, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 9, 2023

Fixes this in editor-sdk7 with latest sdk:

ReferenceError: location is not defined
    at getConfig

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/location-not-defined/dcl-sdk-7.3.14-6132852275.commit-e92ac30.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/location-not-defined/dcl-sdk-commands-7.3.14-6132852275.commit-e92ac30.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/location-not-defined/@dcl/inspector/dcl-inspector-7.3.14-6132852275.commit-e92ac30.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/location-not-defined-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/location-not-defined

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0c0419b) 72.19% compared to head (062eb06) 72.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files         333      333           
  Lines       10866    10866           
  Branches     1449     1448    -1     
=======================================
  Hits         7845     7845           
  Misses       2853     2853           
  Partials      168      168           
Files Changed Coverage Δ
packages/@dcl/inspector/src/lib/logic/config.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala merged commit 82a7824 into main Sep 9, 2023
10 checks passed
@cazala cazala deleted the fix/location-not-defined branch September 9, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant