Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new schemas #732

Merged
merged 5 commits into from
Sep 13, 2023
Merged

feat: support new schemas #732

merged 5 commits into from
Sep 13, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 13, 2023

This PR adapts the @dcl/inspector for the new schemas of @dcl/asset-packs

@cazala cazala requested a review from cyaiox September 13, 2023 15:01
@cazala cazala marked this pull request as ready for review September 13, 2023 16:33
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dceeaf3
Status: ✅  Deploy successful!
Preview URL: https://911db6a1.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-states.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/states/dcl-sdk-7.3.15-6175341059.commit-c675da6.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/states/dcl-sdk-commands-7.3.15-6175341059.commit-c675da6.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/states/@dcl/inspector/dcl-inspector-7.3.15-6175341059.commit-c675da6.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/states-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/states

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b6e1264) 72.24% compared to head (dceeaf3) 72.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files         333      333           
  Lines       10916    10916           
  Branches     1454     1454           
=======================================
  Hits         7886     7886           
  Misses       2862     2862           
  Partials      168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala enabled auto-merge (squash) September 13, 2023 16:53
@cazala cazala merged commit 761f180 into main Sep 13, 2023
10 checks passed
@cazala cazala deleted the feat/states branch September 13, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants