Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: analytics for quests #733

Merged
merged 2 commits into from
Sep 14, 2023
Merged

feat: analytics for quests #733

merged 2 commits into from
Sep 14, 2023

Conversation

lauti7
Copy link
Contributor

@lauti7 lauti7 commented Sep 14, 2023

No description provided.

@lauti7 lauti7 requested review from gonpombo8 and a team September 14, 2023 14:50
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 60df379
Status: ✅  Deploy successful!
Preview URL: https://d5ddb862.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-quests-analytics.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/quests-analytics/dcl-sdk-7.3.15-6189482116.commit-aac526f.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/quests-analytics/dcl-sdk-commands-7.3.15-6189482116.commit-aac526f.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/quests-analytics/@dcl/inspector/dcl-inspector-7.3.15-6189482116.commit-aac526f.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/quests-analytics-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/quests-analytics

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (761f180) 72.24% compared to head (60df379) 72.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   72.24%   72.18%   -0.06%     
==========================================
  Files         333      333              
  Lines       10916    10924       +8     
  Branches     1454     1454              
==========================================
  Hits         7886     7886              
- Misses       2862     2870       +8     
  Partials      168      168              
Files Changed Coverage Δ
...ges/@dcl/sdk-commands/src/commands/quests/index.ts 59.29% <0.00%> (-4.52%) ⬇️
...ages/@dcl/sdk-commands/src/components/analytics.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gonpombo8 gonpombo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only concern is if its ok that we send a message to segment

} else {
const error = (await res.json()) as { code: number; message: string }
const { code, message } = (await res.json()) as { code: number; message: string }
components.analytics.track('Quest Created Failure', { code, message })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure that we want to send this message ? isn't enough with the code ?
I dont know what this message could be but if we are already sending a code we can then map that failure with the message

@lauti7 lauti7 merged commit 1b76fe4 into main Sep 14, 2023
9 of 10 checks passed
@lauti7 lauti7 deleted the feat/quests-analytics branch September 14, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants