-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: analytics for quests #733
Conversation
Deploying with Cloudflare Pages
|
Test this pull request
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 72.24% 72.18% -0.06%
==========================================
Files 333 333
Lines 10916 10924 +8
Branches 1454 1454
==========================================
Hits 7886 7886
- Misses 2862 2870 +8
Partials 168 168
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only concern is if its ok that we send a message to segment
} else { | ||
const error = (await res.json()) as { code: number; message: string } | ||
const { code, message } = (await res.json()) as { code: number; message: string } | ||
components.analytics.track('Quest Created Failure', { code, message }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure that we want to send this message ? isn't enough with the code ?
I dont know what this message could be but if we are already sending a code we can then map that failure with the message
No description provided.