Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent smart items from showing in the catalog when they are disabled #738

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 15, 2023

Prevent smart items from showing in the catalog when they are disabled

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad7c95f
Status: ✅  Deploy successful!
Preview URL: https://2463f56b.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-disable-smart-items-ca.js-sdk-toolchain.pages.dev

View logs

@cazala cazala enabled auto-merge (squash) September 15, 2023 17:34
@github-actions
Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/disable-smart-items-catalog/dcl-sdk-7.3.15-6201067848.commit-06114cd.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/disable-smart-items-catalog/dcl-sdk-commands-7.3.15-6201067848.commit-06114cd.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/disable-smart-items-catalog/@dcl/inspector/dcl-inspector-7.3.15-6201067848.commit-06114cd.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/disable-smart-items-catalog-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/disable-smart-items-catalog

@cazala cazala merged commit 767716e into main Sep 15, 2023
8 checks passed
@cazala cazala deleted the chore/disable-smart-items-catalog branch September 15, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants