Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject createClientTransport promise if socket is closed #741

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

hugoArregui
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5220df7
Status: ✅  Deploy successful!
Preview URL: https://42efc505.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-network-connection.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix-network-connection/dcl-sdk-7.3.16-6251998792.commit-0875d86.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix-network-connection/dcl-sdk-commands-7.3.16-6251998792.commit-0875d86.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix-network-connection/@dcl/inspector/dcl-inspector-7.3.16-6251998792.commit-0875d86.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix-network-connection-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix-network-connection

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -5.45% ⚠️

Comparison is base (791a824) 78.06% compared to head (5220df7) 72.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   78.06%   72.61%   -5.45%     
==========================================
  Files         137      364     +227     
  Lines        4362    12135    +7773     
  Branches      760     1644     +884     
==========================================
+ Hits         3405     8812    +5407     
- Misses        882     3136    +2254     
- Partials       75      187     +112     

see 242 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugoArregui hugoArregui merged commit 0785c75 into main Sep 20, 2023
9 of 10 checks passed
@hugoArregui hugoArregui deleted the fix-network-connection branch September 20, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants