Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styles in TriggerComponent #750

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: styles in TriggerComponent #750

merged 1 commit into from
Sep 26, 2023

Conversation

nicoecheza
Copy link
Contributor

Screen Shot 2023-09-26 at 10 40 55

@nicoecheza nicoecheza enabled auto-merge (squash) September 26, 2023 13:44
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6fac938
Status: ✅  Deploy successful!
Preview URL: https://4438cd8f.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-styles.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/styles/dcl-sdk-7.3.16-6313723360.commit-d7134f0.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/styles/dcl-sdk-commands-7.3.16-6313723360.commit-d7134f0.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/styles/@dcl/inspector/dcl-inspector-7.3.16-6313723360.commit-d7134f0.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/styles-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/styles

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2a4da19) 72.61% compared to head (ca90ce4) 72.61%.
Report is 1 commits behind head on main.

❗ Current head ca90ce4 differs from pull request most recent head 6fac938. Consider uploading reports for the commit 6fac938 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files         367      367           
  Lines       12204    12204           
  Branches     1641     1641           
=======================================
  Hits         8862     8862           
  Misses       3155     3155           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza merged commit 01f87ad into main Sep 26, 2023
7 of 8 checks passed
@nicoecheza nicoecheza deleted the fix/styles branch September 26, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants