Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: asset import #760

Merged
merged 2 commits into from
Oct 4, 2023
Merged

improve: asset import #760

merged 2 commits into from
Oct 4, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Oct 2, 2023

closes decentraland/sdk#711

🤖 Generated by Copilot at cb81be6

This pull request adds support for importing KTX2 compressed textures in the inspector, improves the UI and validation logic of the import asset modal, and fixes a bug in the file input component. It also adds a new utility function to generate a random asset name and tests for it. It modifies the ImportAsset.tsx, utils.ts, utils.spec.ts, FileInput.tsx, fs-utils.ts, and Texture/utils.ts files, and adds a new ImportAsset.css file.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d74dca4
Status: ✅  Deploy successful!
Preview URL: https://c6828c81.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-texture-validation.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/texture-validation/dcl-sdk-7.3.18-6407298291.commit-7b4abe5.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/texture-validation/dcl-sdk-commands-7.3.18-6407298291.commit-7b4abe5.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/texture-validation/@dcl/inspector/dcl-inspector-7.3.18-6407298291.commit-7b4abe5.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/texture-validation-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/texture-validation

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (beb3642) 71.27% compared to head (24f5ad9) 72.73%.

❗ Current head 24f5ad9 differs from pull request most recent head d74dca4. Consider uploading reports for the commit d74dca4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   71.27%   72.73%   +1.45%     
==========================================
  Files         381      368      -13     
  Lines       12587    12460     -127     
  Branches     1701     1695       -6     
==========================================
+ Hits         8972     9063      +91     
+ Misses       3414     3210     -204     
+ Partials      201      187      -14     
Files Coverage Δ
...@dcl/inspector/src/components/ImportAsset/utils.ts 100.00% <100.00%> (ø)
...kages/@dcl/inspector/src/lib/babylon/setup/init.ts 81.08% <100.00%> (ø)
...@dcl/inspector/src/lib/data-layer/host/fs-utils.ts 90.90% <100.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza force-pushed the add/texture-validation branch 3 times, most recently from 25e814e to 24f5ad9 Compare October 3, 2023 15:32
@nicoecheza nicoecheza marked this pull request as ready for review October 3, 2023 15:32
@nicoecheza nicoecheza merged commit d7b961d into main Oct 4, 2023
8 checks passed
@nicoecheza nicoecheza deleted the add/texture-validation branch October 4, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Texture import from local file system
2 participants