Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: play_sound undefined values #764

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: play_sound undefined values #764

merged 1 commit into from
Oct 4, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Oct 4, 2023

The play_sound action was working fine with pre-popullated values from smart items, but when creating an action from scratch it throws due to undefined values, because the typings were wrong (not using Partial).

This PR fixes that.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48a663e
Status: ✅  Deploy successful!
Preview URL: https://791b3fcd.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-play-sound.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/play-sound/dcl-sdk-7.3.18-6407622962.commit-a46a186.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/play-sound/dcl-sdk-commands-7.3.18-6407622962.commit-a46a186.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/play-sound/@dcl/inspector/dcl-inspector-7.3.18-6407622962.commit-a46a186.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/play-sound-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/play-sound

@cazala cazala enabled auto-merge (squash) October 4, 2023 14:55
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d7b961d) 71.48% compared to head (48a663e) 71.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   71.48%   71.47%   -0.02%     
==========================================
  Files         382      382              
  Lines       12678    12680       +2     
  Branches     1703     1703              
==========================================
  Hits         9063     9063              
- Misses       3414     3416       +2     
  Partials      201      201              
Files Coverage Δ
...Inspector/ActionInspector/PlaySoundAction/types.ts 0.00% <0.00%> (ø)
...Inspector/ActionInspector/PlaySoundAction/utils.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala merged commit a5b8e13 into main Oct 4, 2023
8 of 10 checks passed
@cazala cazala deleted the fix/play-sound branch October 4, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants