Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old observabels logic #935

Merged
merged 2 commits into from
May 8, 2024
Merged

remove old observabels logic #935

merged 2 commits into from
May 8, 2024

Conversation

gonpombo8
Copy link
Contributor

merge when decentraland/unity-renderer#6163 reaches prod.

Copy link

cloudflare-workers-and-pages bot commented Apr 24, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5934dca
Status: ✅  Deploy successful!
Preview URL: https://2a932723.js-sdk-toolchain.pages.dev
Branch Preview URL: https://remove-old-observables.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/old-observables/dcl-sdk-7.4.22-9004399004.commit-5e2ee64.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/old-observables/dcl-sdk-commands-7.4.22-9004399004.commit-5e2ee64.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/old-observables/@dcl/inspector/dcl-inspector-7.4.22-9004399004.commit-5e2ee64.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/remove/old-observables-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=remove/old-observables

@gonpombo8 gonpombo8 merged commit 4096037 into main May 8, 2024
8 checks passed
@gonpombo8 gonpombo8 deleted the remove/old-observables branch May 8, 2024 16:18
@gonpombo8 gonpombo8 changed the title [DO NOT MERGE] remove old observabels logic remove old observabels logic May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant