Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove magic cube #938

Merged
merged 3 commits into from
Apr 29, 2024
Merged

fix: remove magic cube #938

merged 3 commits into from
Apr 29, 2024

Conversation

cazala
Copy link
Member

@cazala cazala commented Apr 26, 2024

Remove "Magic Cube" from autogenerated main.composite on workspaces that don't have a composite when using the @dcl/inspector

This caused an issue that if you open a non-Editor project with the Editor, and then open the Visual Editor, the inspector would autogenerate a composite with the Magic Cube for that project.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/remove-magic-cube/dcl-sdk-7.4.21-8860339369.commit-13df0b8.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/remove-magic-cube/dcl-sdk-commands-7.4.21-8860339369.commit-13df0b8.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/remove-magic-cube/@dcl/inspector/dcl-inspector-7.4.21-8860339369.commit-13df0b8.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/remove-magic-cube-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/remove-magic-cube

@AlejandroAlvarezMelucciDCL
Copy link
Contributor

image
I'm not sure what that is, looks like it's not related to this PR, but in the Files changed list I see that. Maybe while you're working on this PR can you fix it?

Copy link

cloudflare-workers-and-pages bot commented Apr 27, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d95f90
Status: ✅  Deploy successful!
Preview URL: https://46ce21a7.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-remove-magic-cube.js-sdk-toolchain.pages.dev

View logs

@cazala
Copy link
Member Author

cazala commented Apr 27, 2024

@AlejandroAlvarezMelucciDCL yep that one slipped thru! good catch :) fixed ✅

@cazala cazala merged commit 079ef41 into main Apr 29, 2024
8 checks passed
@cazala cazala deleted the fix/remove-magic-cube branch April 29, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants